Skip to content

feat: Table Column Groups Table#4482

Open
NathanZlion wants to merge 68 commits into
mainfrom
dev-v3-natidere-table-group
Open

feat: Table Column Groups Table#4482
NathanZlion wants to merge 68 commits into
mainfrom
dev-v3-natidere-table-group

Conversation

@NathanZlion
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion commented Apr 30, 2026

Description

Add Table Column Grouping Feature support for Table Component.

Related links, issue AWSUI-9594, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion changed the title chore: Add test page and interface change for table feat: Table Column Groups Table May 3, 2026
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-table-group branch from 40c20ee to 84451af Compare May 4, 2026 13:42
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 99.18534% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.50%. Comparing base (ff60ea3) to head (62cfc58).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/table/column-groups/utils.ts 99.20% 1 Missing ⚠️
src/table/header-cell/group-header-cell.tsx 96.00% 1 Missing ⚠️
src/table/sticky-scrolling.ts 0.00% 1 Missing ⚠️
src/table/table-role/grid-navigation.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
+ Coverage   97.45%   97.50%   +0.05%     
==========================================
  Files         942      947       +5     
  Lines       29716    30145     +429     
  Branches    10800    10980     +180     
==========================================
+ Hits        28959    29393     +434     
- Misses        710      745      +35     
+ Partials       47        7      -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NathanZlion NathanZlion force-pushed the dev-v3-natidere-table-group branch from 84451af to e9f4fd0 Compare May 4, 2026 15:59
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-table-group branch from d6a98cb to 5cec8c8 Compare May 5, 2026 14:22
@NathanZlion NathanZlion marked this pull request as ready for review May 6, 2026 08:36
@NathanZlion NathanZlion requested a review from a team as a code owner May 6, 2026 08:36
@NathanZlion NathanZlion requested review from georgylobko and removed request for a team and georgylobko May 6, 2026 08:36
@NathanZlion NathanZlion marked this pull request as draft May 6, 2026 11:40
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-table-group branch from 8da3b07 to 227f21b Compare May 8, 2026 00:37
Both tests only verified the resizer element exists then dragged it
without asserting any width change. Resize math is already covered by
unit tests in column-groups.test.tsx, and real-browser drag behavior
is covered by resizable-columns.test.ts.
Comment thread src/table/__tests__/column-groups.test.tsx Outdated
…sizer

Per pan-kot's review and earlier discussion with Gethin/Andrei: combine
data-column-index (for grouped tables) with the existing nth-child path
(for non-grouped tables and backward compat with older component
versions). Also apply data-group-level to all grouped header rows
(including the leaf row) so the nth-child branch reliably no-ops in
grouped tables, avoiding multi-element matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants